pr 리뷰 알림 발동 조건 변경 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- codeowners를 통한 리뷰어 자동 등록이 review request를 3번 발동시키는 현상때문에 알람이 여러번 전송되는 문제 해결을 위함 - web29 팀에 대한 리뷰 요청이 마지막에 취소되는 것을 이용하여 발동 조건을 `review_request_remove`로 설정하였음.
parkblo
requested review from
heegenie and
fru1tworld
and removed request for
a team
3 tasks
fru1tworld
approved these changes
Nov 12, 2024
|
따봉비봇아 고마워 🐝 |
heegenie
added a commit
that referenced
this pull request
Nov 12, 2024
* fix: pr 리뷰 알림 발동 조건 변경 (#82) chore: pr 리뷰 알림 발동 조건 변경 - codeowners를 통한 리뷰어 자동 등록이 review request를 3번 발동시키는 현상때문에 알람이 여러번 전송되는 문제 해결을 위함 - web29 팀에 대한 리뷰 요청이 마지막에 취소되는 것을 이용하여 발동 조건을 `review_request_remove`로 설정하였음. * feat: 기본 node 컴포넌트 구현 * feat: head node UI 구현 * feat: 노트 노드 ui 구현 --------- Co-authored-by: Byeongju Park <[email protected]> Co-authored-by: CatyJazzy <[email protected]> Co-authored-by: heegenie <[email protected]> Co-authored-by: Heejin Na <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 한 줄 설명
✅ 작업 내용
🏷️ 관련 이슈
📌 리뷰 진행 시 참고 사항
예상치 못하게 슬랙봇을 잘 동작시키기가 어렵네요. ㅎㅎ 커밋 이력을 더 더럽히지 않기 위해서 앞으로는 main 브랜치 수정이 아닌 PR을 꼭 올리도록 하겠습니다.